[PATCH] D107020: [test] Fix tools/gold/X86/comdat-nodeduplicate.ll on non-X86 hosts

Nathan Chancellor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 18:55:32 PDT 2021


nathanchance created this revision.
nathanchance added reviewers: MaskRay, tejohnson.
Herald added subscribers: pengfei, kristof.beyls.
nathanchance requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When running this test on an aarch64 machine, it fails:

  /usr/bin/ld.gold: error: .../test/tools/gold/X86/Output/comdat-nodeduplicate.ll.tmp/ab.lto.o: incompatible target

Specify the elf_x86_64 emulation as all of the other gold plugin tests
do.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107020

Files:
  llvm/test/tools/gold/X86/comdat-nodeduplicate.ll


Index: llvm/test/tools/gold/X86/comdat-nodeduplicate.ll
===================================================================
--- llvm/test/tools/gold/X86/comdat-nodeduplicate.ll
+++ llvm/test/tools/gold/X86/comdat-nodeduplicate.ll
@@ -8,7 +8,7 @@
 ; RUN: llvm-as %t/b.ll -o %t/b.bc
 ; RUN: llvm-as %t/c.ll -o %t/c.bc
 
-; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext --plugin-opt=save-temps \
+; RUN: %gold -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold%shlibext --plugin-opt=save-temps \
 ; RUN:   -u foo %t/a.bc --start-lib %t/b.bc --end-lib -o %t/ab
 
 ; RUN: FileCheck %s --check-prefix=RESOL_AB < %t/ab.resolution.txt
@@ -20,7 +20,7 @@
 ; DATA: 0x[[#%x,]] 01000000 00000000  ........
 
 ;; __profc_foo from c.bc is non-prevailing and thus discarded.
-; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext --plugin-opt=save-temps \
+; RUN: %gold -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold%shlibext --plugin-opt=save-temps \
 ; RUN:   -u foo -u c %t/a.bc --start-lib %t/b.bc %t/c.bc --end-lib -o %t/abc
 ; RUN: FileCheck %s --check-prefix=RESOL_ABC < %t/abc.resolution.txt
 ; RUN: llvm-readelf -x .data %t/abc | FileCheck %s --check-prefix=DATA
@@ -35,7 +35,7 @@
 ; RUN: opt --module-summary %t/b.ll -o %t/b.bc
 ; RUN: opt --module-summary %t/c.ll -o %t/c.bc
 
-; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext \
+; RUN: %gold -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold%shlibext \
 ; RUN:   -u foo %t/a.bc --start-lib %t/b.bc %t/c.bc --end-lib -o %t/abc
 ; RUN: llvm-readelf -x .data %t/abc | FileCheck %s --check-prefix=DATA
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107020.362603.patch
Type: text/x-patch
Size: 1541 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210729/01495269/attachment.bin>


More information about the llvm-commits mailing list