[PATCH] D106930: [ThinLTO] Disallow importing for functions with indir branch to block address

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/test/ThinLTO/X86/globals-import-blockaddr.ll:11
+; Verify that bar is not imported since it has address-taken block that is target of indirect branch
+; CHECK-NOT: available_externally [1 x i8*]* @bar
 
----------------
tejohnson wrote:
> This only checks that there isn't an imported copy of bar defined after the imported copy of foo. Either add the same CHECK-NOT prior to the CHECK for foo, or make it a positive sense check for the declare of bar. Probably the latter is cleaner.
Good catch, changed to positive check. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106930/new/

https://reviews.llvm.org/D106930