[PATCH] D106807: [libc][NFC] Add noreturn and constexpr qualifiers to appropriate C lib functions

Siva Chandra via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 09:15:46 PDT 2021


sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

The frequent updates and repeated pinging of reviewers is almost like spamming us.
Please see https://llvm.org/docs/Contributing.html#how-to-submit-a-patch where it says that a good practice is to ping after a week of silence.

Again, don't get me wrong - I totally appreciate you doing this but we all have our own jobs and work which makes patches like this drop down in priority.  That said, I have accepted this patch and will submit it for you some time day (US west coast time).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106807/new/

https://reviews.llvm.org/D106807



More information about the llvm-commits mailing list