[PATCH] D106943: [AArch64][SVE] Fix incorrect mask type when lowering fixed type SVE scatter

Bradley Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 08:10:13 PDT 2021


bsmith added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4455
     StoreVal = convertToScalableVector(DAG, IndexVT, StoreVal);
+    Mask = DAG.getNode(
+        ISD::ZERO_EXTEND, DL,
----------------
sdesmalen wrote:
> Do we need to do the same in LowerMGATHER?
The gathers actually work correctly already, (as can be seen in test/CodeGen/AArch64/sve-fixed-length-masked-gather.ll). This was solely an issue with scatters, (they work slightly differently in this regard).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106943/new/

https://reviews.llvm.org/D106943



More information about the llvm-commits mailing list