[PATCH] D106660: [DebugInfo][InstrRef] Don't break up return-sequences on debug-info instructions

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro accepted this revision.
djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1663
     // sequence, so we return true in that case.
-    return MI.isDebugValue();
+    return MI.isDebugInstr();
 
----------------
Orlando wrote:
> jmorse wrote:
> > djtodoro wrote:
> > > Should it be `isMetaInstruction()` ?
> > The implications of this are unclear to me -- the "KILL" instruction for example manually edits register liveness information, and I'm not sure where in a termination sequence it would belong. IMO, best to keep the change so as small an amount of behaviours as possible, hence picking isDebugInstr.
> SGTM. I just want to check that @djtodoro is happy with this too?
All good. I agree with Jeremy that other meta instructions shouldn't affect this piece of code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106660/new/

https://reviews.llvm.org/D106660