[PATCH] D106850: [InstCombine] Simplify llvm.vscale when vscale_range attribute exists

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 07:02:54 PDT 2021


frasercrmck added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5787
+        return nullptr;
+      unsigned MinScalarVectorSize, MaxScalarVectorSize;
+      std::tie(MinScalarVectorSize, MaxScalarVectorSize) =
----------------
david-arm wrote:
> nit: I think 'Scalar' here is a bit confusing as that's kind of the opposite of 'Vector'. Perhaps 'Scalable' is better?
Yeah. Or `VScaleMin` and `VScaleMax`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106850/new/

https://reviews.llvm.org/D106850



More information about the llvm-commits mailing list