[PATCH] D106856: [LiveDebugValues] Cleanup Transfers when removing Entry Value Location

[Nikola Tesic via Phabricator via llvm-commits]

ntesic added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp:1244-1245
 
+/// Do cleanup of \p EntryValTransfers created by \p TRInst, by removing the
+/// Transfer, which uses the to-be-deleted \p EntryVL.
+bool VarLocBasedLDV::cleanupEntryValueTransfers(const MachineInstr *TRInst,
----------------
jmorse wrote:
> Always returns true -> should instead be void? This disguises the fact that `removeEntryValue` always intends to return true when it calls this function.
I agree. I should definitely find more elegant way to call the `cleanupEntryValueTransfers` .


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106856/new/

https://reviews.llvm.org/D106856