[PATCH] D106850: [InstCombine] Simplify llvm.vscale when vscale_range attribute exists

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 05:10:51 PDT 2021


david-arm added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5787
+        return nullptr;
+      unsigned MinSVEVectorSize, MaxSVEVectorSize;
+      std::tie(MinSVEVectorSize, MaxSVEVectorSize) = Attr.getVScaleRangeArgs();
----------------
frasercrmck wrote:
> I'd say that `SVE` isn't a good variable name here since RISC-V will also use this attribute at some point.
Ah, good spot @frasercrmck ! Sorry I missed that. :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106850/new/

https://reviews.llvm.org/D106850



More information about the llvm-commits mailing list