[PATCH] D106918: [x86] improve CMOV codegen by pushing add into operands, part 3

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:49972
+  if (OtherOp.getOpcode() == ISD::ADD && OtherOp.hasOneUse() &&
+      !isa<ConstantSDNode>(OtherOp.getOperand(0)) &&
+      all_of(N->uses(), [&](SDNode *Use) {
----------------
We usually canonicalize add constants to RHS - does this actually cause problems?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106918/new/

https://reviews.llvm.org/D106918