[PATCH] D106775: [MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to /lib/Target/.

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 03:06:12 PDT 2021


andreadb added a comment.

In D106775#2908396 <https://reviews.llvm.org/D106775#2908396>, @holland11 wrote:

> I have just removed the `AMDGPUTargetMCA` line from the `AMDGPUCodeGen` cmake file. I was originally just following the patterns that I saw from the other folders and classes in that directory and then afterwards I went through and tried to remove things that didn't seem necessary. I guess I missed that one.
>
> Tested it on both macOS and linux and it seems to still work properly. CodeGen definitely doesn't depend on TargetMCA so it was not necessary to have that line.
>
> Will let the build test do its thing and if it looks good, I'll push this patch and watch the build bots closely in case I need to revert.

Sounds good. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106775/new/

https://reviews.llvm.org/D106775



More information about the llvm-commits mailing list