[PATCH] D106927: [WIP][ELFDumper] Refactor some of the helper functions to a header file.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 27 23:58:26 PDT 2021


jhenderson added reviewers: MaskRay, rupprecht, grimar.
jhenderson added a comment.

Could you provide some explanation as to why you need this code in your downstream tools, please? On the surface of it, I don't like this change (for a start, there's too much implementation in headers). An explanation of your use-cases may help provide an alternative approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106927/new/

https://reviews.llvm.org/D106927



More information about the llvm-commits mailing list