[PATCH] D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF.

Tue Jul 27 21:07:29 PDT 2021

Esme added inline comments.

================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:202
+                         ? Obj.Header.NumberOfSymTableEntries
+                         : InitFileHdr.NumberOfSymTableEntries);
+  } else {
----------------
shchenz wrote:
> number of entries in symbol table should be after `SymbolTableOffset`. This should align with XCOFF32?
We should not change the order.
In XCOFF32, the order of fields is SymbolTableOffset, NumberOfSymTableEntries, AuxHeaderSize, Flags.
In XCOFF64, the order is SymbolTableOffset, AuxHeaderSize, Flags, NumberOfSymTableEntries.

================
Comment at: llvm/test/tools/yaml2obj/XCOFF/basic-doc64.yaml:73
+# CHECK64-NEXT:     Index: 3
+# CHECK64-NEXT:     Name: .data
+# CHECK64-NEXT:     PhysicalAddress: 0x0
----------------
shchenz wrote:
> The physicaladdress and the virtualaddress should be not 0 as the previous section's size is 8?
It's a non-data/text/bss section, so the address is set to 0 as the spec required. I will change the section type to bss to check the address value. thx.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100375/new/

https://reviews.llvm.org/D100375