[PATCH] D106622: [BPF] support btf_tag attribute in .BTF section

Yonghong Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 27 17:01:19 PDT 2021


yonghong-song added a comment.

I may have some other inconsistencies. I will double check all in the next revision.



================
Comment at: llvm/lib/Target/BPF/BTF.h:109
   /// Bit     31: kind_flag, currently used by
-  ///             struct, union and fwd
+  ///             struct, union, fwd and attr
   uint32_t Info;
----------------
anakryiko wrote:
> s/attr/tag/ ?
ya.


================
Comment at: llvm/lib/Target/BPF/BTF.h:116
   /// "Type" is used by PTR, TYPEDEF, VOLATILE, CONST, RESTRICT,
-  /// FUNC, FUNC_PROTO and VAR.
+  /// FUNC, FUNC_PROTO, VAR and ATTR.
   /// "Type" is a type_id referring to another type.
----------------
anakryiko wrote:
> s/ATTR/TAG/?
ya.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106622/new/

https://reviews.llvm.org/D106622



More information about the llvm-commits mailing list