[PATCH] D106621: [DWARF] Support new TAG DW_TAG_LLVM_annotation

[Yonghong Song via Phabricator via llvm-commits]

yonghong-song added inline comments.


================
Comment at: llvm/test/DebugInfo/attr-btf_tag.ll:14
+;
+;   int __tag1 __tag2 foo(struct t1 __tag1 __tag2 *arg) {
+;     return arg->a;
----------------
anakryiko wrote:
> looking at CHECK tests below, seems like __tag1 and __tag2 are associated with the arg parameter, right? A bit surprised with syntax, I was expecting something like `struct t1 *arg __tag1 __tag2`, would such variant also work?
`struct t1 *arg __tag1 __tag2` will have the same effect as `struct t1 __tag1 __tag2 *arg`. But I will change example to have the syntax as you suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106621/new/

https://reviews.llvm.org/D106621