[PATCH] D106922: [Bazel] Make td_library usable as data

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/mlir/tblgen.bzl:105
+    # Note that we include srcs in runfiles. A td_library doesn't compile to
+    # produce on the output: it's just a depset of source files and include
+    # directories. So if it is needed for execution of some rule (likely
----------------
"to produce on the output" is difficult to parse for me


================
Comment at: utils/bazel/llvm-project-overlay/mlir/tblgen.bzl:267
 
+    # Note: not using merge_all, as that is not available in Bazel 4.0
+    runfiles = ctx.runfiles(
----------------
High-level comment here too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106922/new/

https://reviews.llvm.org/D106922