[PATCH] D106915: Add a DIExpression const-folder to prevent silly expressions

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 27 16:07:23 PDT 2021


aprantl added a comment.

Thanks for looking into this! Is there any advantage to return a Constant+DIExpression, or could we just return a DIExpression(DW_OP_constu, ...)? Or can we not do that because even after folding the constant is > 64bits?
I think this new API would be a great candidate to create a unit test harness for (perhaps in MetadataTest.cpp).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106915/new/

https://reviews.llvm.org/D106915



More information about the llvm-commits mailing list