[PATCH] D106897: [lld][WebAssembly] Prefer objdump -d over obj2yaml for tests. NFC
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 27 15:45:19 PDT 2021
sbc100 added a comment.
In D106897#2908810 <https://reviews.llvm.org/D106897#2908810>, @sbc100 wrote:
> In D106897#2908772 <https://reviews.llvm.org/D106897#2908772>, @dschuff wrote:
>
>> but anyway this change is fine.
>> I guess one advantage of using objdump over obj2yaml when they are equivalent might be if we can get the whole test in one tool invocation instead of 2.
>
> I think the difference is that ELF sections don't have headers... I think all the headers are stored centrally for ELF.
Most wasm sections contain all kind of structured data... its not clear exactly what bytes should be considered payload, (think data sections with maybe individual data segments within in it... in that case you can data and metadata interspersed).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106897/new/
https://reviews.llvm.org/D106897
More information about the llvm-commits
mailing list