[PATCH] D106887: [LTO][Legacy] Add new API to check presence of ctor/dtor functions

[Steven Wu via Phabricator via llvm-commits]

steven_wu accepted this revision.
steven_wu added a comment.
This revision is now accepted and ready to land.

LGTM in general. Just two small comments inline. Thanks!



================
Comment at: llvm/tools/llvm-lto/llvm-lto.cpp:404
 /// functionality that's exposed by the C API to list symbols.  Moreover, this
 /// provides testing coverage for modules that have been created in their own
----------------
Can you update the comments here to reflect the current function?


================
Comment at: llvm/tools/llvm-lto/llvm-lto.cpp:420
+    if (TestHasCtorDtor)
+      outs() << Filename << ":" << Module->hasCtorDtor() << "\n";
   }
----------------
Can you make the output to stdout more verbose? `Filename : {0|1}` is not clear even for a testing tool.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106887/new/

https://reviews.llvm.org/D106887