[PATCH] D106896: [flang][OpenMP] Add parsing support for nontemporal clause.

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/include/flang/Parser/parse-tree.h:3380
+// nontemporal-clause -> NONTEMPORAL (variable-name-list)
+struct OmpNontemporalClause {
+  TUPLE_CLASS_BOILERPLATE(OmpNontemporalClause);
----------------
arnamoy10 wrote:
> clementval wrote:
> > Non necessary with update to `OMP.td`
> Thanks for the comments.  However, are you sure about the removal of this struct definition?  Because now from `flang/lib/Parser/openmp-parsers.cpp`, I am getting the following error:
> 
> ```
> flang/lib/Parser/openmp-parsers.cpp:153:23: error: ‘OmpNontemporalClause’ was not declared in this scope 
> 153 | TYPE_PARSER(construct<OmpNontemporalClause>(nonemptyList(name)))
> ```
> Thanks for the help.
Yeah but you have to remove it everywhere. Your parser will be `parenthesized(nonemptyList(name))`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106896/new/

https://reviews.llvm.org/D106896