[PATCH] D106775: [MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to /lib/Target/.

[Patrick Holland via Phabricator via llvm-commits]

holland11 updated this revision to Diff 362152.
holland11 added a comment.

I have just removed the `AMDGPUTargetMCA` line from the `AMDGPUCodeGen` cmake file. I was originally just following the patterns that I saw from the other folders and classes in that directory and then afterwards I went through and tried to remove things that didn't seem necessary. I guess I missed that one.

Tested it on both macOS and linux and it seems to still work properly. CodeGen definitely doesn't depend on TargetMCA so it was not necessary to have that line.

Will let the build test do its thing and if it looks good, I'll push this patch and watch the build bots closely in case I need to revert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106775/new/

https://reviews.llvm.org/D106775

Files:
  llvm/CMakeLists.txt
  llvm/cmake/modules/LLVM-Config.cmake
  llvm/docs/CommandGuide/llvm-mca.rst
  llvm/include/llvm/Config/TargetMCAs.def.in
  llvm/include/llvm/Config/llvm-config.h.cmake
  llvm/include/llvm/MCA/CustomBehaviour.h
  llvm/include/llvm/Support/TargetRegistry.h
  llvm/include/llvm/Support/TargetSelect.h
  llvm/lib/Target/AMDGPU/CMakeLists.txt
  llvm/lib/Target/AMDGPU/MCA/AMDGPUCustomBehaviour.cpp
  llvm/lib/Target/AMDGPU/MCA/AMDGPUCustomBehaviour.h
  llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt
  llvm/tools/llvm-mca/CMakeLists.txt
  llvm/tools/llvm-mca/CodeRegionGenerator.h
  llvm/tools/llvm-mca/lib/AMDGPU/AMDGPUCustomBehaviour.cpp
  llvm/tools/llvm-mca/lib/AMDGPU/AMDGPUCustomBehaviour.h
  llvm/tools/llvm-mca/lib/AMDGPU/CMakeLists.txt
  llvm/tools/llvm-mca/lib/CMakeLists.txt
  llvm/tools/llvm-mca/llvm-mca.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106775.362152.patch
Type: text/x-patch
Size: 26074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210727/2dc2c740/attachment.bin>