[PATCH] D106912: [ARM] Fix llvm-objdump disassembly of armv7m object files.

[Eli Friedman via Phabricator via llvm-commits]

efriedma created this revision.
efriedma added reviewers: peter.smith, dmgreen, MaskRay, SjoerdMeijer.
Herald added subscribers: danielkiss, rupprecht, hiraditya, kristof.beyls, emaste.
Herald added a reviewer: jhenderson.
efriedma requested review of this revision.
Herald added a project: LLVM.

Apparently, the features were getting mixed up, so we'd try to disassemble in ARM mode. Fix sub-architecture detection to compute the correct triple if we're detecting it automatically, so the user doesn't need to pass --triple=thumb etc.

It's possible we should be somehow tying the "+thumb-mode" target feature more directly to Tag_CPU_arch_profile? But this seems to work reasonably well, anyway.

While I'm here, fix up the other llvm-objdump tests that were explicitly specifying an ARM triple; that shouldn't be necessary.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106912

Files:
  llvm/lib/Object/ELFObjectFile.cpp
  llvm/test/tools/llvm-objdump/ELF/ARM/v5t-subarch.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v5te-subarch.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v5tej-subarch.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v6-neg-subfeatures.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v6-subarch.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v6-subfeatures.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v6k-subarch.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v6m-subarch.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v6t2-subarch.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v7a-neg-subfeature.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v7a-subfeature.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v7m-neg-subfeatures.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v7m-subarch.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v7m-subfeatures.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v8a-subarch.s
  llvm/test/tools/llvm-objdump/ELF/ARM/v8r-subarch.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106912.362149.patch
Type: text/x-patch
Size: 9474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210727/de15f853/attachment.bin>