[PATCH] D106893: [flang] Disallow BOZ literal constants as output list items
Pete Steinfeld via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 27 12:39:51 PDT 2021
PeteSteinfeld added inline comments.
================
Comment at: flang/lib/Semantics/expression.cpp:159
int GetRank(std::size_t) const;
- bool IsBOZLiteral(std::size_t i) const {
- return std::holds_alternative<BOZLiteralConstant>(GetExpr(i).u);
- }
+ bool IsBOZLiteral(std::size_t i) const { return IsBozLiteral(GetExpr(i)); }
void SayNoMatch(const std::string &, bool isAssignment = false);
----------------
klausler wrote:
> It would be great if you could use the same capitalization for both of these predicates.
Thanks, Peter. Will do.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106893/new/
https://reviews.llvm.org/D106893
More information about the llvm-commits
mailing list