[PATCH] D106672: [AMDGPU][GlobalIsel] Fix unable to legalize G_CONCAT_VECTORS when loading a vector.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:230
+
+  LLT LCMTy = getLCMType(ResultTy, LeftoverTy);
+  // Check if G_CONCAT_VECTORS or G_BUILD_VECTOR would be illegal for the types
----------------
In general I don't think legalization action implementations should be concerned with the legality of what they are producing (beyond heuristics to choose a more optimal lowering). i.e. this patch should not solve a legalization failure


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106672/new/

https://reviews.llvm.org/D106672