[PATCH] D106758: [AMDGPU] We would need FP if there is call and caller save VGPR spills

[Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits]

RamNalamothu updated this revision to Diff 362113.
RamNalamothu added a comment.

Merged `test/CodeGen/AMDGPU/need-fp-from-csr-vgpr-spill.ll` and `llvm/test/CodeGen/AMDGPU/need-fp-from-caller-save-vgpr-spill.ll` into `test/CodeGen/AMDGPU/need-fp-from-vgpr-spills.ll`.

>>> In D106758#2904887 <https://reviews.llvm.org/D106758#2904887>, @arsenm wrote:
>>>
>>>> LGTM except the test is using dead code. I also think we ought to be able to remove VGPRReservedForSGPRSpill now that SGPR and VGPR allocation are split
>>>
>>> I think that's out of the scope for this review.
>>
>> Yes, but would be a good follow up change.

OK, will try that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106758/new/

https://reviews.llvm.org/D106758

Files:
  llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
  llvm/test/CodeGen/AMDGPU/gfx-callable-preserved-registers.ll
  llvm/test/CodeGen/AMDGPU/need-fp-from-csr-vgpr-spill.ll
  llvm/test/CodeGen/AMDGPU/need-fp-from-vgpr-spills.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106758.362113.patch
Type: text/x-patch
Size: 19677 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210727/87833810/attachment.bin>