[PATCH] D106807: [libc] Add noreturn, constexpr, and static_cast qualifiers to appropriate C lib functions

Tue Jul 27 10:22:55 PDT 2021

sivachandra added a comment.

I have marked those files in which the changes are OK. Please update and I can submit this patch for you.

================
Comment at: libc/src/__support/integer_operations.h:14
 namespace __llvm_libc {

----------------
Changes in this file OK.

================
Comment at: libc/src/ctype/ctype_utils.h:18
 // of a function call by inlining them.
 // ------------------------------------------------------
----------------
Changes in this file OK.

================
Comment at: libc/utils/HdrGen/Command.h:36
   public:
     ErrorReporter(llvm::SMLoc L, llvm::SourceMgr &SM) : Loc(L), SrcMgr(SM) {}
----------------
Changes in this file OK.

================
Comment at: llvm/include/llvm/Support/Compiler.h:27
 #endif

----------------
You will need to move the changes in this file out to a different patch and get it reviewed by a suitable reviewer. Also, as I have suggested previously, do not mixup style cleanups with the actual intention of the patches.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106807/new/

https://reviews.llvm.org/D106807