[PATCH] D106843: [IVDescriptors] Fix bug in checkOrderedReduction
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 27 07:10:23 PDT 2021
fhahn added inline comments.
================
Comment at: llvm/test/Transforms/LoopVectorize/fp-reduction-crash.ll:1
+; REQUIRES: asserts
+; RUN: opt < %s -loop-vectorize -S | FileCheck %s
----------------
anna wrote:
> kmclaughlin wrote:
> > nit: I don't think `REQUIRES: asserts` is necessary for this test?
> This is to show that the failure only occurs in assertions enabled mode. It will not fail in any other mode.
>
> To put it differently, if I first landed this testcase alone, it will succeed in non-assertion enabled mode and it isn't clear what the problem is (since we cannot add `XFAIL`).
>
Can you add check lines to make sure the IR is transformed as expected? That way, we do not need to rely on the asserting causing the test to crash.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106843/new/
https://reviews.llvm.org/D106843
More information about the llvm-commits
mailing list