[PATCH] D106843: [IVDescriptors] Fix bug in checkOrderedReduction

[Anna Thomas via Phabricator via llvm-commits]

anna added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/fp-reduction-crash.ll:1
+; REQUIRES: asserts
+; RUN: opt < %s -loop-vectorize -S | FileCheck %s
----------------
kmclaughlin wrote:
> nit: I don't think `REQUIRES: asserts` is necessary for this test?
This is to show that the failure only occurs in assertions enabled mode. It will not fail in any other mode.

To put it differently, if I first landed this testcase alone, it will succeed in non-assertion enabled mode and it isn't clear what the problem is (since we cannot add `XFAIL`). 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106843/new/

https://reviews.llvm.org/D106843