[PATCH] D106857: [RISCV] Teach VSETVLI insertion to merge the unused VSETVLI with the one need to be insert after it.

Jianjian Guan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 27 06:17:04 PDT 2021


jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:636
   VSETVLIInfo CurInfo;
+  MachineInstr *VSetMI = nullptr;
 
----------------
frasercrmck wrote:
> Could this be a property of `VSETVLIInfo` somehow? It seems odd to track two separate bits of state.
> 
> If not I think the variable needs a better name.
Done, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106857/new/

https://reviews.llvm.org/D106857



More information about the llvm-commits mailing list