[PATCH] D106512: [RISCV] Remove the _COMMUTABLE and _TA versions of FMA and wide FMA vector instructions.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 27 04:52:11 PDT 2021


frasercrmck added a comment.

I think the summary/description should reference D105092 <https://reviews.llvm.org/D105092>?

If I've got this right, now all FMA pseudos are ostensibly "commutable" as far as LLVM's concerned, but we skip the optimization if the tail policy argument says otherwise?

I'm a bit concerned that LLVM has (at least in theory) the right to assume these instructions are commutable by checking the static `MI.isCommutable()` method without asking us about the tail policy. Maybe that's academic, I dunno.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106512/new/

https://reviews.llvm.org/D106512



More information about the llvm-commits mailing list