[PATCH] D105344: [DAGCombiner] Fold SETCC(FREEZE(x),const) to FREEZE(SETCC(x,const)) if SETCC is used by BRCOND

Tue Jul 27 00:38:55 PDT 2021

aqjune marked 2 inline comments as done.
aqjune added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10260
+                         ISD::isUnsignedIntSetCC(Cond) ||
+                         ISD::isIntEqualitySetCC(Cond);
+  if (PreferSetCC && IsIntComparison) {
----------------
efriedma wrote:
> I don't think the IsIntComparison check does anything.  The cod codes are shared between int and fp ops.  The way to check if you have an integer comparison is just to check the types of the operands... which you're implicitly doing by casting to ConstantSDNode.
Didn't realize that ConstantSDNode only has an integer, thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105344/new/

https://reviews.llvm.org/D105344