[PATCH] D106213: [lld-macho] Enable copy-on-write for input buffers

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D106213#2889390 <https://reviews.llvm.org/D106213#2889390>, @int3 wrote:

> Right now, pretty small. (0.3% for the internal build I'm testing, and 0.002% for chromium_framework.) But I'm building upon this to apply ICF to functions that have unwind info, since CompactUnwindEntries use unsigned section relocations -- which embed their addends -- to refer to functions. This has a much larger impact -- 3.2% for the internal build, about doubling the impact that ICF currently has. Not sure about chromium_framework yet, as my implementation is currently crashing.

How much size win do you need to catch up to ld64?

(It's probably clear that I'm asking because this seems like a somewhat ugly change conceptually, and I'm wondering if it's worth it.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106213/new/

https://reviews.llvm.org/D106213