[PATCH] D106720: [WIP][Attributor] AAFunctionReachability, Instruction reachability.

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8691
+      return true;
+    };
+
----------------
jdoerfert wrote:
> Don't accumulate pointers to containers but content instead.
I tried using references here. But I couldn't pass SmallVector<const AACallEdges &> as a ArrayRef.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8835-8836
+    for (auto QueryPair : InstQueries) {
+      Change = Change | checkReachableBackwards(A, QueryPair.second);
+    }
+
----------------
jdoerfert wrote:
> `|=`, also elsewhere
> no braces.
Oh great. I am happy to hear that someone finally added that operator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106720/new/

https://reviews.llvm.org/D106720