[PATCH] D106780: [x86] Fix lowering to illegal type in LowerINSERT_VECTOR_ELT

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm marked 2 inline comments as done.
xiangzhangllvm added inline comments.


================
Comment at: llvm/test/CodeGen/X86/vector_double2_insert.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -O0 -mtriple i686-pc-win32-msvc -mcpu=skx               | FileCheck %s
+
----------------
RKSimon wrote:
> RKSimon wrote:
> > We'd probably be better off adding i686 triple coverage to llvm/test/CodeGen/X86/avx-insertelt.ll to get much better coverage:
> > ```
> > ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx  | FileCheck %s --check-prefixes=ALL,AVX
> > ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2 | FileCheck %s --check-prefixes=ALL,AVX2,X64-AVX2
> > ; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+avx2 | FileCheck %s --check-prefixes=ALL,AVX2,X86-AVX2
> > ```
> Sorry that should be llvm/test/CodeGen/X86/insertelement-var-index.ll - add at least one AVX2 or later RUN with i686 triple:
> 
> ```
> ; RUN: llc < %s -mtriple=x86_64-- -mattr=+avx2   | FileCheck %s --check-prefixes=ALL,AVX,AVX1OR2,AVX2,X64-AVX2
> ; RUN: llc < %s -mtriple=i686--   -mattr=+avx2   | FileCheck %s --check-prefixes=ALL,AVX,AVX1OR2,AVX2,X86-AVX2
> ```
There already "-mtriple=x86_64-- -mattr=+avx2 " here, so add "-mtriple=i686--   -mattr=+avx2" thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106780/new/

https://reviews.llvm.org/D106780