[PATCH] D106338: Use GNUInstallDirs to define install locations for documentation

Mon Jul 26 16:10:48 PDT 2021

t-tye added a comment.

In D106338#2905365 <https://reviews.llvm.org/D106338#2905365>, @scott.linder wrote:

> I think the change itself LGTM, but I did a grep for GNUInstallDirs and it it only used in two other places currently. I suppose that means it is OK to use, but it does seem to imply there can be cases where we install to inconsistent locations. I don't know who to add to get more info on this, though?

Right. I did check and saw GNUInstallDirs was being used elsewhere in relation to the documentation installing. So making this change seemed consistent. I think all documentation installing is now using GNUInstallDirs, but I did not check how other non-documentation install rules are being done. I would be happy to update this review if someone can advise.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106338/new/

https://reviews.llvm.org/D106338