[PATCH] D104431: [lld] Add lto-pgo-warn-mismatch option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/thinlto-pgo-warn.ll:3
+
+; Basic ThinLTO tests.
+; RUN: opt -module-summary %s -o %t1.bc
----------------
Newer lld/test/ELF tests use `;;` for non-RUN-non-CHECK comments.


================
Comment at: lld/test/ELF/lto/thinlto-pgo-warn.ll:8
+; Ensure lld generates warnings for profile cfg mismatch.
+; RUN: ld.lld --lto-cs-profile-file=%t2.profdata --lto-pgo-warn-mismatch --plugin-opt=thinlto --plugin-opt=O2 -shared %t1.bc -o /dev/null 2>&1 | FileCheck %s
+
----------------
Drop --plugin-opt=thinlto

`--lto-O2`


================
Comment at: lld/test/ELF/lto/thinlto-pgo-warn.ll:11
+; Ensure lld will not generate warnings for profile cfg mismatch.
+; RUN: ld.lld --lto-cs-profile-file=%t2.profdata --no-lto-pgo-warn-mismatch --plugin-opt=thinlto --plugin-opt=O2 -shared %t1.bc -o /dev/null 2>&1 | not FileCheck %s
+
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104431/new/

https://reviews.llvm.org/D104431