[PATCH] D106769: [MemCpyOpt] Relax libcall checks

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: llvm/test/Transforms/MemCpyOpt/no-libcalls.ll:3
+; RUN: opt -S -memcpyopt < %s | FileCheck %s --check-prefixes=CHECK,LIBCALLS
+; RUN: opt -S -memcpyopt -mtriple=amdgcn-- < %s | FileCheck %s --check-prefixes=CHECK,NO-LIBCALLS
+
----------------
asbirlea wrote:
> tra wrote:
> > This is a bit ironic as AMDGPU back-end (as well as NVPTX) *can* actually handle memory intrinsics w/o the matching libcalls.
> > 
> > https://godbolt.org/z/Koedbzn5x
> > 
> > I think it may make sense to fold D106401 into this patch and add another test for AMDGPU + all optimizations enabled by the flag.
> Either folding into this or as a separate patch is reasonable IMO. 
> @tra: do you have another test that would be relevant to add in D106401 for nvptx (beside an additional RUN line in this one with the flag I mean)? 
If the flag is folded into this patch, we should have a test for it (see my comment above). I'll add it to D106401 if it's not folded in.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106769/new/

https://reviews.llvm.org/D106769