[PATCH] D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction

Chris Jackson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 26 14:17:06 PDT 2021


chrisjackson updated this revision to Diff 361797.
chrisjackson added a comment.

Applied changes requested by @jmorse: changed accessors to use SmallVectorImpl and added a comment in pushCast().
The path covering the salvage of dbg.value that were changed from single location op to multi location op by LSR is covered already e.g. debuginfo-scev-salvage-1.ll. I'm not certain how to make this clear as all the modifications to the intrinsic occur within the pass.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105207/new/

https://reviews.llvm.org/D105207

Files:
  llvm/include/llvm/Transforms/Utils/ScalarEvolutionExpander.h
  llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
  llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp
  llvm/test/Transforms/LoopStrengthReduce/dbg-preserve-0.ll
  llvm/test/Transforms/LoopStrengthReduce/dbg-preserve-2.ll
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-salvage-0.ll
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-salvage-1.ll
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-salvage-2.ll
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-salvage-3.ll
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-salvage-4.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105207.361797.patch
Type: text/x-patch
Size: 60911 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210726/4baa5ae8/attachment.bin>


More information about the llvm-commits mailing list