[PATCH] D104641: Strip undef implying attributes when moving calls

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 26 13:58:00 PDT 2021


anna added a comment.

In D104641#2903135 <https://reviews.llvm.org/D104641#2903135>, @jdoerfert wrote:

> Rebase on 087a8eea359a <https://reviews.llvm.org/rG087a8eea359a4d8ef22c42fddca3b09833928c6a> should make it a bit smaller. I'm unsure why the nonnull is listed in `PopulateUndefImplyingAttributes` I guess after the rebase it will be gone and the tests that drop it won't anymore.
>
> seems there are no more real concerns, so LGTM if the rebase works out as expected.

Thanks @jdoerfert. I'll give it a day if anyone has concerns over the rebased code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104641/new/

https://reviews.llvm.org/D104641



More information about the llvm-commits mailing list