[PATCH] D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0

Craig E Rasmussen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 26 12:12:33 PDT 2021


craig.rasmussen added a comment.

How do I ping?  I have another pull request that is also in limbo.

Thanks,
Craig

From: Diana Picus via Phabricator <reviews at reviews.llvm.org>
Date: Monday, July 26, 2021 at 8:45 AM
To: Rasmussen, Craig E. <rasmussen17 at llnl.gov>, jh7370 at my.bristol.ac.uk <jh7370 at my.bristol.ac.uk>, sscalpone at nvidia.com <sscalpone at nvidia.com>, diana.picus at linaro.org <diana.picus at linaro.org>
Cc: maskray at google.com <maskray at google.com>, llvm-commits at lists.llvm.org <llvm-commits at lists.llvm.org>, mgorny at gentoo.org <mgorny at gentoo.org>, rupprecht at google.com <rupprecht at google.com>, bhuvanendra.kumarn at amd.com <bhuvanendra.kumarn at amd.com>, yanliang.mu at intel.com <yanliang.mu at intel.com>, dougpuob at gmail.com <dougpuob at gmail.com>, tim at tkeith.com <tim at tkeith.com>, kuhnel at google.com <kuhnel at google.com>
Subject: [PATCH] D105595 <https://reviews.llvm.org/D105595>: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0
rovka added a comment.

In D105595#2894946 <https://reviews.llvm.org/D105595#2894946> <https://urldefense.us/v3/__https://reviews.llvm.org/D105595*2894946__;Iw!!G2kpM7uM-TzIFchu!j8TcPSbVUpRWmsqLEU_2NiAJlQkuOPOamifPnxDhHpBXqKbAyypxYlbd08Z4MU1Ca6WH$ >, @craig.rasmussen wrote:

> Requesting review (is there a better way to request a review)

I think people usually notice and have another look when you upload a new version of the patch. If there's no reaction, common practice is to ping about once a week.

CHANGES SINCE LAST ACTION

  https://urldefense.us/v3/__https://reviews.llvm.org/D105595/new/__;!!G2kpM7uM-TzIFchu!j8TcPSbVUpRWmsqLEU_2NiAJlQkuOPOamifPnxDhHpBXqKbAyypxYlbd08Z4MWbf3AVF$<https://urldefense.us/v3/__https:/reviews.llvm.org/D105595/new/__;!!G2kpM7uM-TzIFchu!j8TcPSbVUpRWmsqLEU_2NiAJlQkuOPOamifPnxDhHpBXqKbAyypxYlbd08Z4MWbf3AVF$>

https://urldefense.us/v3/__https://reviews.llvm.org/D105595__;!!G2kpM7uM-TzIFchu!j8TcPSbVUpRWmsqLEU_2NiAJlQkuOPOamifPnxDhHpBXqKbAyypxYlbd08Z4MfUDIKSg$https://urldefense.us/v3/__https:/reviews.llvm.org/D105595__;!!G2kpM7uM-TzIFchu!j8TcPSbVUpRWmsqLEU_2NiAJlQkuOPOamifPnxDhHpBXqKbAyypxYlbd08Z4MfUDIKSg$


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105595/new/

https://reviews.llvm.org/D105595



More information about the llvm-commits mailing list