[PATCH] D106816: [AArch64][GlobalISel] Add identity combines to post-legal combiner.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 26 11:59:22 PDT 2021


aemerson added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-identity.mir:18
+    ; CHECK: RET_ReallyLR implicit $x0
+    %a:_(s64) = G_CONSTANT i64 40
+    %b:_(s64) = G_CONSTANT i64 0
----------------
jroelofs wrote:
> Maybe the LHS ought to be a copy from a phys reg, so this test doesn't get accidentally repurposed if someone adds a constant-folding combines to it.
Good point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106816/new/

https://reviews.llvm.org/D106816



More information about the llvm-commits mailing list