[PATCH] D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 26 10:32:41 PDT 2021


efriedma added a comment.

No testcases?



================
Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:656
              MMO->getFailureOrdering() != AtomicOrdering::AcquireRelease);
       FailureOrdering =
+          getMergedAtomicOrdering(FailureOrdering, MMO->getFailureOrdering());
----------------
Isn't this just equivalent to `FailureOrdering = MMO->getFailureOrdering()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106729/new/

https://reviews.llvm.org/D106729



More information about the llvm-commits mailing list