[PATCH] D106776: [GlobalISel] Add a constant folding combine.

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 26 09:23:24 PDT 2021


paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4259
+
+void CombinerHelper::applyConstantFold(MachineInstr &MI, APInt &MatchInfo) {
+  Builder.setInstrAndDebugLoc(MI);
----------------
This looks like it could use `replaceInstWithConstant`; does it need APInt? (Or should that helper be changed to use APInt?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106776/new/

https://reviews.llvm.org/D106776



More information about the llvm-commits mailing list