[PATCH] D106412: [llvm-objcopy][MachO] Ignore all LC_SUB_* commands.
Daniel RodrÃguez Troitiño via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 26 09:19:03 PDT 2021
drodriguez added a comment.
In D106412#2903649 <https://reviews.llvm.org/D106412#2903649>, @MaskRay wrote:
> I'll rename PayloadString to Content in D106759 <https://reviews.llvm.org/D106759>
Thanks. I will rename here, test again, and send and update.
================
Comment at: llvm/test/tools/llvm-objcopy/MachO/sub-load-commands.test:6
+# RUN: llvm-objcopy %t %t2
+# RUN: llvm-objdump --macho --private-headers %t2 | FileCheck %s
+
----------------
smeenai wrote:
> Can we also `cmp` the before and after binaries? They should be identical, right?
I don't know. Probably. I will check and add the comparison if so.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106412/new/
https://reviews.llvm.org/D106412
More information about the llvm-commits
mailing list