[PATCH] D106532: [ARM] Attempt to distribute reductions

[Nicholas Guy via Phabricator via llvm-commits]

NickGuy accepted this revision.
NickGuy added a comment.
This revision is now accepted and ready to land.

Apart from a personal gripe (which I feel shouldn't stop this being merged), LGTM



================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:13103-13104
+      unsigned N0RedOp = 0;
+      if (!IsVecReduce(N0.getOperand(N0RedOp)))
+        N0RedOp = 1;
+      if (!IsVecReduce(N0.getOperand(N0RedOp)))
----------------
If this IsVecReduce returns true, then the second will run needlessly. I'd prefer if the second invocation was conditional on the first failing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106532/new/

https://reviews.llvm.org/D106532