[PATCH] D105008: [VPlan] Add recipe for first-order rec phis, make splicing explicit.

Mon Jul 26 07:53:21 PDT 2021

fhahn added a comment.

In D105008#2903352 <https://reviews.llvm.org/D105008#2903352>, @thakis wrote:

> In D105008#2903350 <https://reviews.llvm.org/D105008#2903350>, @thakis wrote:
>
>> This makes clang assert (in +Asserts builds) or crash (in -Asserts builds) in this standalone repro: https://bugs.chromium.org/p/chromium/issues/detail?id=1232798#c2
>
> Reverted for now in b1777b04dc4b1a9fee0e7effa7e177892ab32ef0 <https://reviews.llvm.org/rGb1777b04dc4b1a9fee0e7effa7e177892ab32ef0>

Thanks for the reproducer & revert!

The underlying issue was that we were using VPValues fetched for the stored values in the original IR, rather than the potentially modified stored values in the memory recipes. that should be fixed in d995d6376 <https://reviews.llvm.org/rGd995d63767624a60a5d3276f9f16d7b995435af1>. I added a reduced version of the reproducer as test in 93664503be6b <https://reviews.llvm.org/rG93664503be6b3f47269cf617f8c46b6ce95f8076>. And I now recommitted the patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105008/new/

https://reviews.llvm.org/D105008