[PATCH] D106659: [DebugInfo][InstrRef] Handle llvm.frameaddress intrinsics gracefully

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:1206
+    // locations.
+    ;
   } else {
----------------
The empty `if` body looks a little odd but makes sense to me. I don't think you need the `;` though, unless this is to match prior art? No strong opinion.


================
Comment at: llvm/test/DebugInfo/X86/instr-ref-framereg-read.ll:7-8
+; Today, as a concession, we emit a DBG_PHI allowing the frame register value
+; to be read, but it could be expressed in other ways. Check that this works
+; outside of the entry block.
+
----------------
Why is it important to check outside of the entry block (it might be worth adding to the comment in the test too, ymmv)?


================
Comment at: llvm/test/DebugInfo/X86/instr-ref-framereg-read.ll:25
+  ret i8 *%0
+}
+
----------------
nit: there seems to be some wobbly indentation above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106659/new/

https://reviews.llvm.org/D106659