[PATCH] D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests

[Maryam via Phabricator via llvm-commits]

MaryamBen marked an inline comment as done.
MaryamBen added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll:14
+; RUN:     --xcoff-traceback-table=false -filetype=obj -o %t.o < %s
+; RUN: llvm-readobj --syms %t.o | FileCheck --check-prefixes SYM,SYM64 %s
 
----------------
jhenderson wrote:
> You may wish to add --match-full-lines to here and the equvialent 32-bit FileCheck command. There's the potential for a false pass in lines like the following:
> 
> ```
> ; SYM64:         SymbolAlignmentLog2: 3
> ```
> That line could match any of the following output:
> ```
> SymbolAlignmentLog2: 3
> SymbolAlignmentLog2: 32
> SymbolAlignmentLog2: 32131241251
> ```
> 
> etc.
In some cases the abstraction is used to combine the 32/64 bit.

If you think it's better, I will add it whenever it's possible. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104644/new/

https://reviews.llvm.org/D104644