[PATCH] D106139: [DAGCombine] Combine srX of add that intends to get the carry as uaddo

[Abinav Puthan Purayil via Phabricator via llvm-commits]

abinavpp added a comment.

In D106139#2897256 <https://reviews.llvm.org/D106139#2897256>, @arsenm wrote:

> I still think there is something wrong if you need to consider the truncated and non truncated case.

I haven't found an input where this transformation can go wrong, I'm not sure if we missed a corner case.

In D106139#2897256 <https://reviews.llvm.org/D106139#2897256>, @arsenm wrote:

> Are we missing an add width reduction case?

The width reduction is implied in the basicXXX and truncUse functions in the added test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106139/new/

https://reviews.llvm.org/D106139