[PATCH] D106312: [AMDGPU] Allow rematerialization of virtual reg uses

Mon Jul 19 15:59:39 PDT 2021

rampitec added a comment.

In D106312#2888820 <https://reviews.llvm.org/D106312#2888820>, @arsenm wrote:

> In D106312#2888802 <https://reviews.llvm.org/D106312#2888802>, @rampitec wrote:
>
>> In D106312#2888778 <https://reviews.llvm.org/D106312#2888778>, @arsenm wrote:
>>
>>> I don't follow this. Why would we want to override the generic logic and extend live ranges? If the LRE checks that it doesn't extend the live range, why not just remove the generic check?
>>
>> It does not extend live ranges, I have added a test for it. The comment is likely just obsolete. But then if I simply remove the check from the generic implementation a lot of tests in other targets start to fail. These must have their own restrictions which do not apply to us.
>
> This could also just mean code improvements. You can't just assume these are incorrect changes without looking. I don't see much special going on in the other target implementations

Using vreg without a def is not an improvement, just as other sorts of failed verification.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106312/new/

https://reviews.llvm.org/D106312