[PATCH] D106397: [Attributor] Use CFG reasoning to filter potentially interfering writes

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1184
+        if (DomAcc != &Acc &&
+            DT->dominates(Acc.getLocalInst(), DomAcc->getLocalInst())) {
+          return true;
----------------
I don't understand why we can ignore a store here.

Even if `Acc` dominates a store here doesn't mean that there can't be path from `Acc` that 
doesn't go through `DomAcc` right ? it only means that the  execution must pass through 
`Acc` before reaching `DomAcc` or am I confused ? 

Wouldn't it make more sense to use the post-dominator tree here ? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106397/new/

https://reviews.llvm.org/D106397